After working on a task and it’s ready for review, please check the following:
General
- Personal branches in bitbucket shouldn’t really be used by other developers
- You still need to manage your code in the development branches
- It is NOT other people’s responsibility to manage your code
- Please ensure your code is in the relevant development branches!
- It is fine to commit your personal code in your personal branch as a back-up before having it ready for review
Updating to In Review
- Please ensure all code is committed to development
- development MUST always be up to date so the other developers can update their personal branches
- We shouldn’t manage code other developers branches
- Please ensure that development code is merged to the revelant *-dev branch
- microservices and micro front-end modules need to be merged so that it is ready for testing
- The only exception is kman-client-webapp – please create a PR
- Update the JIRA task to In Review
When updating Feedback: Needs Update
IMPORTANT: Never leave any tasks in Feedback: Needs Update
This status is used so there has been feedback to the developers.
It’s not used for checking progress.
- Move the task back to In Progress
- Make relevant updates
- Follow the Updating to In Review steps above
- Move task status to In Review